-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade serialize-javascript #11434
Merged
Merged
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhaddiMu
approved these changes
Jun 28, 2020
Hi. When will this pull request be merged? |
ermanzohre
approved these changes
Jul 16, 2020
I have the same security problem as @sugiyama-akina , a merge is planned soon please ? |
ermanzohre
approved these changes
Jul 17, 2020
Justineo
approved these changes
Aug 13, 2020
@yyx990803 will there be a new 2.6 release containing this security fix? If yes, when can we expect it? :) |
SillyFreak
added a commit
to PRIArobotics/delete-your-data
that referenced
this pull request
Aug 14, 2020
…t ~2.12 for now. vulnerable serialize-javascript@<3.1.0 is now only present as a dependency of vue-server-renderer, which is being worked on: vuejs/vue#11434
2.6.12 has been released. |
Great! Thank you very much! ❤ |
Closed
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Security update from #11427 and https://app.snyk.io/vuln/SNYK-JS-SERIALIZEJAVASCRIPT-570062
Breaking changes listed at https://github.com/yahoo/serialize-javascript/releases
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: